Don't block on API changes vs. the merge base of a PR - #2798
Open
mdboom wants to merge 2 commits into
Open
Conversation
mdboom
added
bug
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The original design of the API checks is that the comparison against the merge base of the PR is purely informational and should not block CI. The reason for this is that it is perfectly fine and reasonable to iterate on an API design during development before it has been released. The informational notes are useful just to prevent doing something like that by accident.
(The API comparisons against the latest release of cuda-core remain blocking, however).